Skip to content

Conversation

lewing
Copy link
Member

@lewing lewing commented Apr 4, 2025

Remove nonexistent namespace check and avoid comparing the same 25 characters over and over for every System.Runtime.Intrinsics method.

@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 16:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/mono/mono/mini/interp/transform.c:2610

  • The use of a logical OR here may lead to unintended behavior; double-check if both 'Arm' and 'X86' should be handled together or if an AND condition is intended.
if (strncmp ("Arm", klass_name_space + 26, 3) || !strncmp ("X86", klass_name_space + 26, 3)) {

Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@lewing
Copy link
Member Author

lewing commented Apr 4, 2025

/ba-g We stopped hearing from agent NetCore-Public

@lewing lewing merged commit 5b1ffb8 into dotnet:main Apr 4, 2025
66 of 72 checks passed
@lewing lewing deleted the no-comparison-interp branch April 4, 2025 19:32
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants