-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Remove unused and unnecessary CLRConfig
s.
#114282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (8)
src/coreclr/vm/i386/excepx86.cpp:829
- The removal of the debug-only assertion in the OOM handling path may reduce diagnostic feedback in debug builds; ensure that this change is intended and that alternative diagnostics are in place if needed.
#if defined(_DEBUG)
src/coreclr/vm/codeman.cpp:5146
- [nitpick] Consider renaming 'pwzJitNameMaybe' to a clearer name such as 'tempJitName' or 'jitNameTemp' to enhance code clarity.
LPWSTR pwzJitNameMaybe = NULL;
src/coreclr/vm/appdomain.cpp:922
- The removal of the debug pause loop controlled by 'INTERNAL_PauseOnLoad' should be verified to ensure that it does not impact developers who rely on this mechanism during debugging.
#ifdef _DEBUG
src/coreclr/md/compiler/regmeta.h:2059
- Removal of 'm_bKeepKnownCa' is appropriate for cleaning up unused configurations; please verify that no dependent logic assumes its presence.
bool m_bKeepKnownCa; // Should all known CA's be kept?
src/coreclr/md/compiler/regmeta.cpp:66
- The elimination of 'm_bKeepKnownCa' initialization aligns with the header changes; ensure that metadata attribute processing continues to function as expected.
m_bKeepKnownCa(false),
src/coreclr/md/compiler/custattr_emit.cpp:1027
- Updating attribute handling to use only 'props->bKeepCa' should be verified to ensure that removing 'm_bKeepKnownCa' does not alter the intended behavior for known custom attributes.
*bKeep = props->bKeepCa || m_bKeepKnownCa;
src/coreclr/inc/clrconfigvalues.h:111
- The removal of unused config values like 'INTERNAL_EnableFullDebug' should be cross-checked with all modules to ensure no inadvertent dependencies remain.
CONFIG_DWORD_INFO(INTERNAL_EnableFullDebug, W("EnableFullDebug"), 0, "Heavy-weight checking for AD boundary violations (AD leaks)")
src/coreclr/inc/clrconfigvalues.h:392
- Ensure that the coordinated removal of config values such as 'INTERNAL_MD_ForceNoColDesSharing' and 'INTERNAL_MD_KeepKnownCA' does not affect any legacy code paths or fallback behaviors.
RETAIL_CONFIG_DWORD_INFO(INTERNAL_MD_ForceNoColDesSharing, W("MD_ForceNoColDesSharing"), 0, "Don't know - the only usage I could find is #if 0 (?)")
Tagging subscribers to this area: @mangod9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
No description provided.