-
Notifications
You must be signed in to change notification settings - Fork 5k
Add bootstrapping build mechanism and enable for SourceBuild #114285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2c52e80
7c8bc6e
c5a67c0
5fc4b0a
3ae8a10
ae6824b
6c353f8
4d69c06
b22b99c
64667ef
c12698a
b631070
efeda56
0b066ed
59c078f
f23c641
9400e95
2d6e806
de101ab
54630a9
4c611b1
9fb4c78
bc6ec22
d798f2a
ef6a6f8
053dcae
d109c64
e494fa9
feff1e1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,9 @@ | |
<InnerBuildArgs Condition="'$(OS)' != 'Windows_NT'">$(InnerBuildArgs) --outputrid $(OutputRID)</InnerBuildArgs> | ||
<!-- BaseOS is an expected known rid in the graph that OutputRID is compatible with. | ||
It's used to add OutputRID in the graph if the parent can't be detected. --> | ||
<InnerBuildArgs>$(InnerBuildArgs) /p:AdditionalRuntimeIdentifierParent=$(BaseOS) /p:BaseOS=$(BaseOS)</InnerBuildArgs> | ||
<InnerBuildArgs>$(InnerBuildArgs) /p:AdditionalRuntimeIdentifierParent=$(BaseOS)</InnerBuildArgs> | ||
<!-- Source-build will use non-portable RIDs. To build for these non-portable RID scenarios, we must do a boostrapped build. --> | ||
<InnerBuildArgs Condition="'$(DotNetBuildSourceOnly)' == 'true' and '$(DotNetBuildUseMonoRuntime)' != 'true'">$(InnerBuildArgs) --bootstrap</InnerBuildArgs> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This is good for me. I wonder if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can't use that by itself because that would cause this to trigger on some (but not all) Unified Build legs. For Unified Build, we'll want this on either for 100% of the verticals or never. |
||
<!-- Pass through special build modes controlled by properties --> | ||
<InnerBuildArgs Condition="'$(DotNetBuildRuntimeWasmEnableThreads)' == 'true'">$(InnerBuildArgs) /p:WasmEnableThreads=true</InnerBuildArgs> | ||
<InnerBuildArgs Condition="'$(DotNetBuildMonoEnableLLVM)' != ''">$(InnerBuildArgs) /p:MonoEnableLLVM=$(DotNetBuildMonoEnableLLVM)</InnerBuildArgs> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should fallback to
PortableRuntimeIdentifierGraph.json
as it is default since .NET 8.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to keep this consistent with the non-bootstrapping path below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will likely be removed in the future, since there is no new distro version added in past few years, so it's just a legacy baggage at this point. The distro graph comes from SB and portable graph is used in official builds. Since .NET 10 is going to use VMR for official builds, we may want to double check. (not for this PR)