Skip to content

Conversation

amanasifkhalid
Copy link
Contributor

Fixes #114229.

@Copilot Copilot AI review requested due to automatic review settings April 9, 2025 16:26
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 9, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/coreclr/jit/importer.cpp:12646

  • Removing the likelihood setting could affect the weight distribution of the flow edge; please verify that this change aligns with the intended profiling behavior for finally exits.
newEdge->setLikelihood(1.0 / predCount);

src/coreclr/jit/importer.cpp:12688

  • [nitpick] Ensure that the new fgProfileWeightsConsistentOrSmall function correctly handles all edge cases, specifically when small but significant weights are involved, to avoid misclassification of consistency.
profileConsistent &= fgProfileWeightsConsistentOrSmall(callFinally->bbWeight, callFinallyRet->bbWeight);

@amanasifkhalid
Copy link
Contributor Author

/azp run runtime-coreclr libraries-pgo

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid
Copy link
Contributor Author

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. No diffs. Test failures look unrelated, as I don't see any new profile consistency asserts. Thanks!

@amanasifkhalid
Copy link
Contributor Author

/ba-g blocked by test timeouts

@amanasifkhalid amanasifkhalid merged commit e231b75 into dotnet:main Apr 9, 2025
112 of 119 checks passed
@amanasifkhalid amanasifkhalid deleted the importer-consistency-check-tolerance branch April 9, 2025 21:59
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed '!"Inconsistent profile data"' during 'Importation'

2 participants