Skip to content

Conversation

lewing
Copy link
Member

@lewing lewing commented Apr 10, 2025

this includes #114493

@Copilot Copilot AI review requested due to automatic review settings April 10, 2025 17:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/mono/mono/mini/interp/simd-methods.def: Language not supported
Comments suppressed due to low confidence (2)

src/mono/mono/mini/interp/transform-simd.c:1231

  • SN_ConvertToSingle is added as a convert alias but lacks an explicit method name assignment like SN_ConvertToInt32's 'ConvertToInt32Saturate'. Verify if the fall-through behavior in this switch-case grouping is intentional.
case SN_ConvertToSingle:

src/mono/mono/mini/interp/transform-simd.c:1237

  • SN_Sqrt is introduced as a convert alias and handled in the same switch-case group without a dedicated method name assignment. Confirm that this grouping and fall-through behavior is as intended.
case SN_Sqrt:

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

@lewing lewing merged commit 8f8dad0 into dotnet:main Apr 10, 2025
63 of 68 checks passed
@lewing lewing deleted the add-convert branch April 10, 2025 22:52
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants