[mono][interp] Avoid doing extra lookups when not needed #114517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewing
requested review from
BrzVlad,
kotlarmilos,
steveisok and
vitek-karas
as code owners
ghost
added
the
| static gboolean | ||
| emit_sri_vector128 (TransformData *td, MonoMethod *cmethod, MonoMethodSignature *csignature) | ||
| { | ||
| if (csignature->hasthis) |
There was a problem hiding this comment.
Consider adding an inline comment explaining that the early return based on 'hasthis' in this function is intended to avoid extra intrinsic lookups and improve performance.
Copilot uses AI. Check for mistakes.
| static gboolean | ||
| emit_sri_packedsimd (TransformData *td, MonoMethod *cmethod, MonoMethodSignature *csignature) | ||
| { | ||
| if (csignature->hasthis) |
There was a problem hiding this comment.
For consistency, add a comment here to clarify that the early exit for methods with 'this' pointers prevents redundant lookup operations for intrinsic resolution.
Copilot uses AI. Check for mistakes.
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
This was referenced Apr 11, 2025
javiercn
approved these changes
Apr 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
micro optimization to reduce the cost of not finding a match for an intrinsic that has a name match but an invalid signature.