Disable the UTFStringConversionFailures test on CI runs #114747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…machines can't handle the load from allocating 2 2GB strings and the OOM killer was killing the process.
jkoritzinsky
requested review from
agocke,
AaronRobinsonMSFT,
elinor-fung and
Copilot
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs:113
- Disabling the test reduces CI coverage; please ensure that issue SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts #114241 tracks plans for addressing this or running the test in a memory-optimized environment.
[SkipOnCI("Allocates enough memory that the OOM killer can kill the process on our Helix machines.")]
|
Tagging subscribers to this area: @dotnet/interop-contrib |
AaronRobinsonMSFT
approved these changes
Apr 16, 2025
elinor-fung
approved these changes
Apr 16, 2025
| @@ -110,6 +110,7 @@ public static partial void NegateBoolsRef2D_ClearMarshalling( | |||
| public class CollectionMarshallingFails | |||
| { | |||
| [Fact] | |||
| [SkipOnCI("Allocates enough memory that the OOM killer can kill the process on our Helix machines.")] | |||
| public void UTFStringConversionFailures() | |||
There was a problem hiding this comment.
Would it make sense to name this as something specific to conversion failures due to the long string?
This was referenced Apr 17, 2025
|
/ba-g wasm failures unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the UTFStringConversionFailures test on CI runs as our Helix machines can't handle the load from allocating 2 2GB strings and the OOM killer was killing the process.
Fixes #114241