[release/9.0-staging] Do not set the salt or info if they are NULL for OpenSSL HKDF. #114877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #114864 to release/9.0-staging
/cc @vcsjones
Customer Impact
This issue was found internally by scouting a nightly build of OpenSSL 3.5.1-dev. Customers that use the
HKDF.Expand
on Linux with OpenSSL 3.0 or greater will unconditionally receive an exception:This is due to setting the
salt
parameter to NULL, where OpenSSL wants the set to be omitted entirely when there is nosalt
value. Customers have no means to work around this.Regression
This regressed due to an upstream change in OpenSSL at openssl/openssl#27305, which is cherry-picked for all OpenSSL 3.x releases.
Testing
Existing tests caught the issue when running against OpenSSL 3.5.1-dev. With the changes, the tests are back to green.
Risk
Low. The change is to not set the
salt
andinfo
parameters if they are NULL, instead of setting them to NULL values. The functionality has strong test coverage and existing tests verify the change is correct.IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging
, notrelease/X.0
.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.