backport 111408 #114932
Open
backport 111408 #114932
+89
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR backports changes to support special user mode APC handling in thread suspension and debugging paths.
- Introduces new thread state flags (TS_SSToExitApcCall and TS_SSToExitApcCallDone) and helper methods to manage APC-related thread suspension.
- Adds an overload for HandleSuspensionForInterruptedThread and updates debugger and controller logic to handle single-stepping out of APC calls.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/vm/threadsuspend.cpp | Added APC handling in thread suspension, new method MarkForSuspensionAndWait, and overload for HandleSuspensionForInterruptedThread. |
| src/coreclr/vm/threads.h | Updated thread state flags, friend declarations, and protected member methods. |
| src/coreclr/vm/dbginterface.h, debugger.h, debugger.cpp | Introduced SingleStepToExitApcCall support for APC callbacks during debugging. |
| src/coreclr/debug/ee/controller.cpp | Modified exception dispatch to manage APC exit using the new thread state flags. |
Comments suppressed due to low confidence (1)
src/coreclr/vm/threadsuspend.cpp:4241
- Ensure that the new FEATURE_SPECIAL_USER_MODE_APC code paths, including the APC exit handling, are adequately covered by regression tests to verify both normal and debugger-assisted scenarios.
#ifdef FEATURE_SPECIAL_USER_MODE_APC
| return FALSE; | ||
| } | ||
| pCurThread->SetThreadState(Thread::TS_SSToExitApcCallDone); | ||
| pCurThread->ResetThreadState(Thread::TS_SSToExitApcCall); |
There was a problem hiding this comment.
Verify that the ordering of state flag updates in the APC exit block is consistent with expected behavior and that resetting TS_SSToExitApcCall occurs only after setting TS_SSToExitApcCallDone.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
Tagging subscribers to this area: @mangod9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.