-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[wasm][aot] Fix op_OnesComplement on wasm and enable ceil/floor #115151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the handling of the op_OnesComplement intrinsic on wasm and expands the platform support for ceil/floor SIMD operations.
- Adds new cases for SN_op_UnaryNegation and SN_op_OnesComplement in the SIMD intrinsic switch.
- Expands the conditional compilation for ceil/floor operations to support TARGET_ARM and TARGET_WASM.
kg
reviewed
May 4, 2025
kg
approved these changes
May 4, 2025
lewing
commented
May 5, 2025
/ba-g timeouts are not related |
This was referenced May 8, 2025
Closed
Open
Open
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.