Skip to content

[release/9.0-staging] throw an exception instead of infinite loop in sort_mark_list #115529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

[release/9.0-staging] throw an exception instead of infinite loop in sort_mark_list #115529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
734f7ad
throw an exception instead of infinite loop
May 12, 2025
b9c09bb
Merge branch 'release/9.0-staging' into backport/pr-115492-to-release…
Maoni0 May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/coreclr/gc/gc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10717,6 +10717,14 @@ size_t gc_heap::sort_mark_list()
size_t region_index = get_basic_region_index_for_address (heap_segment_mem (region));
uint8_t* region_limit = heap_segment_allocated (region);

// Due to GC holes, x can point to something in a region that already got freed. And that region's
// allocated would be 0 and cause an infinite loop which is much harder to handle on production than
// simply throwing an exception.
if (region_limit == 0)
{
FATAL_GC_ERROR();
}

uint8_t*** mark_list_piece_start_ptr = &mark_list_piece_start[region_index];
uint8_t*** mark_list_piece_end_ptr = &mark_list_piece_end[region_index];
#else // USE_REGIONS
Expand Down