Skip to content

spelling regex #115699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2025
Merged

spelling regex #115699

merged 6 commits into from
May 19, 2025

Conversation

danmoseley
Copy link
Member

Got tired of the squiggles for thiings like textbeg.

Procedure

  1. Get-ChildItem -Recurse -Filter *.cs | ForEach-Object { Start-Process $_.FullName } in the project folder to get all files open and spell checked
  2. Filter Info messages by "spell", copy into file, and convert into list of words
  3. Fix obvious misspellings

@Copilot Copilot AI review requested due to automatic review settings May 18, 2025 18:58
@danmoseley danmoseley requested a review from stephentoub May 18, 2025 18:58
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes various typos and spelling mistakes across the RegularExpressions codebase and updates the spell dictionary accordingly.

  • Fixed multiple misspellings in XML documentation and inline comments.
  • Updated a variable name to follow proper camelCase naming conventions.
  • Added new spell dictionary entries to support the corrected spellings.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
src/libraries/System.Text.RegularExpressions/src/spell.dic Added spell dictionary entries for regex terms.
SymbolicRegexNode.cs Corrected typos in parameter and inline comments (e.g., "boubd", "susumption", "accumulater", "sigleton").
SymbolicRegexMatcher.Automata.cs Fixed typo in comment ("identifed" → "identified").
SymbolicRegexInfo.cs Corrected misspelling ("resepctive" → "respective").
SymbolicRegexBuilder.cs Fixed typo ("caharcter" → "character") in a comment.
BDDRangeConverter.cs Corrected typo ("consequtive" → "consecutive") in a comment.
RegexTreeAnalyzer.cs Fixed typo ("internaly" → "internally") in a comment.
RegexNode.cs Corrected typo ("descendents" → "descendants") in the XML documentation.
RegexLWCGCompiler.cs Updated variable naming from "tryfindNextPossibleStartPositionMethod" to "tryFindNextPossibleStartPositionMethod".
RegexFindOptimizations.cs Fixed typo ("constitues" → "constitutes") in a comment.
RegexCharClass.cs Corrected typo ("exense" → "expense") in a comment.
RegexCaseEquivalences.cs Fixed typo ("caluclate" → "calculate") in a comment.
Regex.Timeout.cs Corrected typo ("InifiniteMatchTimeout" → "InfiniteMatchTimeout") in a comment.
GeneratedRegexAttribute.cs Fixed typo ("suported" → "supported") in XML documentation.
.editorconfig Updated configuration to exclude the spell dictionary from spell checking.
Comments suppressed due to low confidence (3)

src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexLWCGCompiler.cs:57

  • [nitpick] Renamed variable to follow camelCase; 'tryfindNextPossibleStartPositionMethod' updated to 'tryFindNextPossibleStartPositionMethod'.
DynamicMethod tryFindNextPossibleStartPositionMethod = DefineDynamicMethod($"Regex{regexNum}_TryFindNextPossibleStartingPosition{description}", typeof(bool), typeof(CompiledRegexRunner), s_paramTypes);

src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexLWCGCompiler.cs:64

  • [nitpick] Updated parameter naming in the function call to match the updated variable name.
EmitScan(options, tryFindNextPossibleStartPositionMethod, tryMatchAtCurrentPositionMethod);

src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.Timeout.cs:28

  • Fixed typo: 'InifiniteMatchTimeout' corrected to 'InfiniteMatchTimeout' in the comment.
/// Regex.InfiniteMatchTimeout was created instead of Timeout.InfiniteTimeSpan because of:

@danmoseley danmoseley enabled auto-merge (squash) May 18, 2025 21:03
@danmoseley
Copy link
Member Author

[14:11:29] dbug: All 9 retries of action failed
[14:11:29] warn: No attached devices / emulators detected. Check that any emulators have been started, and attached device(s) are connected via USB, powered-on, unlocked and authorized.
[14:11:29] dbug: No suitable devices found
[14:11:29] crit: Failed to find compatible device: x86_64

@stephentoub do I merge anyway? I can't create a known issue for the above

@danmoseley danmoseley merged commit af6a2c1 into dotnet:main May 19, 2025
81 of 85 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants