-
Notifications
You must be signed in to change notification settings - Fork 5.1k
spelling regex #115699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spelling regex #115699
Conversation
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes various typos and spelling mistakes across the RegularExpressions codebase and updates the spell dictionary accordingly.
- Fixed multiple misspellings in XML documentation and inline comments.
- Updated a variable name to follow proper camelCase naming conventions.
- Added new spell dictionary entries to support the corrected spellings.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 14 comments.
Show a summary per file
File | Description |
---|---|
src/libraries/System.Text.RegularExpressions/src/spell.dic | Added spell dictionary entries for regex terms. |
SymbolicRegexNode.cs | Corrected typos in parameter and inline comments (e.g., "boubd", "susumption", "accumulater", "sigleton"). |
SymbolicRegexMatcher.Automata.cs | Fixed typo in comment ("identifed" → "identified"). |
SymbolicRegexInfo.cs | Corrected misspelling ("resepctive" → "respective"). |
SymbolicRegexBuilder.cs | Fixed typo ("caharcter" → "character") in a comment. |
BDDRangeConverter.cs | Corrected typo ("consequtive" → "consecutive") in a comment. |
RegexTreeAnalyzer.cs | Fixed typo ("internaly" → "internally") in a comment. |
RegexNode.cs | Corrected typo ("descendents" → "descendants") in the XML documentation. |
RegexLWCGCompiler.cs | Updated variable naming from "tryfindNextPossibleStartPositionMethod" to "tryFindNextPossibleStartPositionMethod". |
RegexFindOptimizations.cs | Fixed typo ("constitues" → "constitutes") in a comment. |
RegexCharClass.cs | Corrected typo ("exense" → "expense") in a comment. |
RegexCaseEquivalences.cs | Fixed typo ("caluclate" → "calculate") in a comment. |
Regex.Timeout.cs | Corrected typo ("InifiniteMatchTimeout" → "InfiniteMatchTimeout") in a comment. |
GeneratedRegexAttribute.cs | Fixed typo ("suported" → "supported") in XML documentation. |
.editorconfig | Updated configuration to exclude the spell dictionary from spell checking. |
Comments suppressed due to low confidence (3)
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexLWCGCompiler.cs:57
- [nitpick] Renamed variable to follow camelCase; 'tryfindNextPossibleStartPositionMethod' updated to 'tryFindNextPossibleStartPositionMethod'.
DynamicMethod tryFindNextPossibleStartPositionMethod = DefineDynamicMethod($"Regex{regexNum}_TryFindNextPossibleStartingPosition{description}", typeof(bool), typeof(CompiledRegexRunner), s_paramTypes);
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexLWCGCompiler.cs:64
- [nitpick] Updated parameter naming in the function call to match the updated variable name.
EmitScan(options, tryFindNextPossibleStartPositionMethod, tryMatchAtCurrentPositionMethod);
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.Timeout.cs:28
- Fixed typo: 'InifiniteMatchTimeout' corrected to 'InfiniteMatchTimeout' in the comment.
/// Regex.InfiniteMatchTimeout was created instead of Timeout.InfiniteTimeSpan because of:
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Show resolved
Hide resolved
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Show resolved
Hide resolved
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Show resolved
Hide resolved
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Show resolved
Hide resolved
...ularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexMatcher.Automata.cs
Show resolved
Hide resolved
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexNode.cs
Show resolved
Hide resolved
.../System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexFindOptimizations.cs
Show resolved
Hide resolved
...ibraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCharClass.cs
Show resolved
Hide resolved
...s/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCaseEquivalences.cs
Show resolved
Hide resolved
...System.Text.RegularExpressions/src/System/Text/RegularExpressions/GeneratedRegexAttribute.cs
Show resolved
Hide resolved
@stephentoub do I merge anyway? I can't create a known issue for the above |
Got tired of the squiggles for thiings like
textbeg
.Procedure
Get-ChildItem -Recurse -Filter *.cs | ForEach-Object { Start-Process $_.FullName }
in the project folder to get all files open and spell checked