Add dispose of X509Chain in SignedXml #115909
Merged
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
huoyaoyuan
reviewed
May 22, 2025
| } | ||
| finally | ||
| { | ||
| chain.Dispose(); |
There was a problem hiding this comment.
If only the variable is disposed and nothing else, then using should be better.
This was referenced May 23, 2025
Open
Is OOF until next week, but predicting what Jeremy will say: "Please use a |
MaxPatri
force-pushed
the
Add-X509Chain-dispose-call-in-SignedXml
branch
from
85c875e to
de78f2c
Compare
PranavSenthilnathan
requested changes
May 29, 2025
...libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXml.cs
Outdated
Show resolved
Hide resolved
PranavSenthilnathan
approved these changes
May 29, 2025
stephentoub
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call Dispose for X509Chain class instance
I didn't add chain.ChainElements[*].Certificate.Dispose() as mentioned here
because I'm not sure that we should dispose all chained certificates. One of them is passed through the method parameters
Found by Linux Verification Center (linuxtesting.org) with SVACE.