Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/coreclr/jit/codegenxarch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6173,6 +6173,18 @@ void CodeGen::genCallInstruction(GenTreeCall* call X86_ARG(target_ssize_t stackA
{
retSize = emitTypeSize(retTypeDesc->GetReturnRegType(0));
secondRetSize = emitTypeSize(retTypeDesc->GetReturnRegType(1));

if (retTypeDesc->GetABIReturnReg(1) == REG_INTRET)
Copy link

Copilot AI Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment to explain the rationale for swapping retSize and secondRetSize in situations where the second return register is REG_INTRET, to clarify the underlying assumption about register allocation.

Copilot uses AI. Check for mistakes.

{
// If the second return register is REG_INTRET, then the first
// return is expected to be in a SIMD register.
// The emitter has hardcoded belief that retSize corresponds to
// REG_INTRET and secondRetSize to REG_INTRET_1, so fix up the
// situation here.
assert(!EA_IS_GCREF_OR_BYREF(retSize));
retSize = secondRetSize;
secondRetSize = EA_UNKNOWN;
}
}
else
{
Expand Down
17 changes: 15 additions & 2 deletions src/coreclr/jit/gcencode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,21 @@ ReturnKind GCInfo::getReturnKind()
case 1:
return VarTypeToReturnKind(retTypeDesc.GetReturnRegType(0));
case 2:
return GetStructReturnKind(VarTypeToReturnKind(retTypeDesc.GetReturnRegType(0)),
VarTypeToReturnKind(retTypeDesc.GetReturnRegType(1)));
{
var_types first = retTypeDesc.GetReturnRegType(0);
var_types second = retTypeDesc.GetReturnRegType(1);
#ifdef UNIX_AMD64_ABI
if (varTypeUsesFloatReg(first))
{
// first does not consume an int register in this case so an obj/ref
// in the second ReturnKind would actually be found in the first int reg.
first = second;
Copy link

Copilot AI Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to include a brief comment clarifying why setting 'first' to 'second' and then assigning TYP_UNDEF to 'second' is necessary under UNIX_AMD64_ABI.

Copilot uses AI. Check for mistakes.

second = TYP_UNDEF;
}
#endif // UNIX_AMD64_ABI
return GetStructReturnKind(VarTypeToReturnKind(first),
VarTypeToReturnKind(second));
}
default:
#ifdef DEBUG
for (unsigned i = 0; i < regCount; i++)
Expand Down
9 changes: 9 additions & 0 deletions src/coreclr/vm/method.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1168,6 +1168,15 @@ ReturnKind MethodDesc::ParseReturnKindFromSig(INDEBUG(bool supportStringConstruc
regKinds[i] = RT_Scalar;
}
}

if (eeClass->GetEightByteClassification(0) == SystemVClassificationTypeSSE)
Copy link

Copilot AI Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider expanding the comment to clearly explain why swapping regKinds[0] and regKinds[1] corrects the GC info mismatch when the first eight-byte is classified as SSE.

Copilot uses AI. Check for mistakes.

{
// Skip over SSE types since they do not consume integer registers.
// An obj/byref in the 2nd eight bytes will be in the first integer register.
regKinds[0] = regKinds[1];
regKinds[1] = RT_Scalar;
}

ReturnKind structReturnKind = GetStructReturnKind(regKinds[0], regKinds[1]);
return structReturnKind;
}
Expand Down
42 changes: 42 additions & 0 deletions src/tests/JIT/Regression/JitBlue/Runtime_115815/Runtime_115815.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Threading;
using System.Collections.Generic;
using System.Runtime.CompilerServices;
using Xunit;

public class Runtime_115815
{
[Fact]
public static void TestEntryPoint()
{
var destination = new KeyValuePair<Container, double>[1_000];

// loop to make this method fully interruptible + to get into OSR version
for (int i = 0; i < destination.Length * 1000; i++)
{
destination[i / 1000] = default;
}

for (int i = 0; i < 5; i++)
{
for (int j = 0; j < destination.Length; j++)
{
destination[j] = GetValue(j);
}

Thread.Sleep(10);
}
}

[MethodImpl(MethodImplOptions.NoInlining)]
private static KeyValuePair<Container, double> GetValue(int i)
=> KeyValuePair.Create(new Container(i.ToString()), (double)i);

private struct Container
{
public string Name;
public Container(string name) { this.Name = name; }
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Optimize>True</Optimize>
</PropertyGroup>
<ItemGroup>
<Compile Include="$(MSBuildProjectName).cs" />
</ItemGroup>
</Project>
Loading