Record OperationCanceledException in HttpClient native instrumentation #116269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
Open
3 tasks
Contributor
Author
|
@antonfirsov this PR is ready to be reviewed. |
antonfirsov
approved these changes
Jun 5, 2025
Contributor
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
LGTM assuming tests are passing.
Not sure if it should be considered as a breaking (behavioral) change [...] For example, for .NET 10+, this logic will no longer be necessary
Given that folks typically depend on that OTel polyfill logic anyways and with this PR we are now doing mostly the same, IMO it is unlikely to break many people.
Contributor
Author
|
Failures in CI look unrelated. |
Contributor
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Outerloop failures are also unrelated. |
antonfirsov
added a commit
that referenced
this pull request
Jul 4, 2025
Depending on the timing of the cancellation, the exception type can be either `OperationCanceledException` or `TaskCanceledExcption`, we need to allow both. The PR also refactors the assertions outside of the `ActivityListener` callback, so we get better error messages if something fails in the future. (This test has been recently added in #116269.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116205.
Not sure if it should be considered as a breaking (behavioral) change but with this change, when an
OperationCanceledExceptionoccurs,Activity.Status,error.typetag, andexceptionevent will be set. For example, for .NET 10+, this logic will no longer be necessary: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/3df15a11fd77557d922f8e414914741e18ba1604/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs#L183-L193.