Skip to content

Skip SSL key log test for OpenSSL 3.5+ #116474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

Skip SSL key log test for OpenSSL 3.5+ #116474

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
268c0f9
Skip SSL key log test for openssl 3.5+
rokonec Jun 10, 2025
7bd2edd
Minor changes, active issue comment
rokonec Jun 12, 2025
4fd9615
Conditional return
rokonec Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamRemoteExecutorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public SslStreamRemoteExecutorTests()
[PlatformSpecific(TestPlatforms.Linux)] // SSLKEYLOGFILE is only supported on Linux for SslStream
[InlineData(true)]
[InlineData(false)]
//[ActiveIssue("https://github.com/dotnet/runtime/issues/116473")]
public async Task SslKeyLogFile_IsCreatedAndFilled(bool enabledBySwitch)
{
if (PlatformDetection.IsDebugLibrary(typeof(SslStream).Assembly) && !enabledBySwitch)
Expand All @@ -34,6 +35,13 @@ public async Task SslKeyLogFile_IsCreatedAndFilled(bool enabledBySwitch)
return;
}

if (PlatformDetection.IsOpenSsl3_5 && !enabledBySwitch)
{
// OpenSSL 3.5 and later versions log into file in SSLKEYLOGFILE environment variable by default,
// regardless of AppContext switch.
return;
}

var psi = new ProcessStartInfo();
var tempFile = Path.GetTempFileName();
psi.Environment.Add("SSLKEYLOGFILE", tempFile);
Expand Down
Loading