-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix buffer slicing in (U)Int128 property name serialization #116868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7e8e04d
Initial plan for issue
Copilot 95c1bca
Fix buffer slicing in (U)Int128 property name serialization
Copilot 5d4e9b3
Add regression tests for Int128/UInt128 property name serialization
Copilot debf1a4
Address PR feedback: simplify test assertions and remove junk data ch…
Copilot e7917eb
Add JSON content validation to Int128/UInt128 dictionary tests
Copilot 6bf6af5
Update src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Se…
eiriktsarpalis c219e4c
Replace multiple assertions with single E2E validation in Int128 dict…
Copilot f40d227
Address PR feedback: remove implementation details and add JSON conte…
Copilot 1360919
Replace Assert.Contains with Assert.Equal for E2E JSON validation in …
Copilot 305efb8
Restore multi-key dictionaries in Int128/UInt128 tests as requested
Copilot 9bdc465
Use raw string literals for JSON assertions in Int128/UInt128 tests
Copilot 0422d1b
Remove superficial comments from Int128/UInt128 dictionary tests
Copilot 55a73eb
Merge branch 'main' into copilot/fix-116855
eiriktsarpalis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.