Skip to content

Prerequisite 3 for #105403 (src/coreclr) #117021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Prerequisite 3 for #105403 (src/coreclr) #117021

wants to merge 3 commits into from

Conversation

gwr
Copy link
Contributor

@gwr gwr commented Jun 25, 2025 •
edited
Loading

Prerequisite 3 for #105403
Changes under src/coreclr

gwr added 3 commits June 25, 2025 10:03
@gwr
Fix compile error in coreclr/pal/src/thread/thread.cpp
b111eb3 
  /home/gwr/dotnet/runtime/src/coreclr/pal/src/thread/thread.cpp:1367:5: error: 'cid' was not declared in this scope
   1367 |     cid = CLOCK_THREAD_CPUTIME_ID;
        |     ^~~
@gwr
Fix compile error in coreclr/vm/appdomain.hpp
33d51c5 
 src/coreclr/vm/appdomain.hpp:1934:40: error: declaration of 'constexpr SystemDomain** const cdac_data<SystemDomain>::SystemDomain' changes meaning of 'SystemDomain' [-Wchanges-meaning]
   1934 |     static constexpr PTR_SystemDomain* SystemDomain = &SystemDomain::m_pSystemDomain;
        |                                        ^~~~~~~~~~~~
  src/coreclr/vm/appdomain.hpp:1934:56: note: used here to mean 'class SystemDomain'
   1934 |     static constexpr PTR_SystemDomain* SystemDomain = &SystemDomain::m_pSystemDomain;
        |                                                        ^~~~~~~~~~~~
  src/coreclr/vm/appdomain.hpp:1629:7: note: declared here
   1629 | class SystemDomain final
        |       ^~~~~~~~~~~~
@gwr
Fix compile error in coreclr/runtime/amd64/AllocFast.S
aa40a85 
 coreclr/runtime/amd64/AllocFast.S: Assembler messages:
  coreclr/runtime/amd64/AllocFast.S:237: Error: missing ')'
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 25, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@am11
Copy link
Member

am11 commented Jun 25, 2025 •
edited
Loading

Title of these PRs are pretty meaningless TBH. Suggestion was to open a single PR with illumos build fixes so main branch starts building again and #105403 stays focused on System.Diagnostics.Process namespace changes. We had several such PRs in past dotnet/runtime/pulls (sort:updated-desc is:closed "fix illumos build")

@gwr gwr mentioned this pull request Jun 25, 2025
Open
@gwr
Copy link
Contributor Author

gwr commented Jun 25, 2025

Titles of these PRs are pretty meaningless TBH. Suggestion was to open a single PR with illumos build fixes ...

Sorry, I was trying to be helpful, and I guess I didn't understand what you wanted.
So should I close all these and open one with all the prerequisites?

@am11
Copy link
Member

am11 commented Jun 25, 2025

main branch gets staled on illumos over time because we don't have a CI leg (like runtime (Build freebsd-x64 Debug CoreCLR_Bootstrapped currently running on this PR), so it is a continuous maintenance thing; not necessarily a prerequisite of #105403 (i.e. 105403 and this can be merged in any order).

So should I close all these and open one with all the prerequisites?

From the perspective of "how would it look in git history in the future", I'd say yes, it's better to batch these small miscellaneous build fixes in a single PR.

@gwr gwr changed the title Illumos4c Prerequisite 3 for #105403 (src/coreclr) Jun 25, 2025
@gwr
Copy link
Contributor Author

gwr commented Jun 25, 2025

See #117023

@gwr gwr closed this Jun 25, 2025
@gwr gwr deleted the illumos4c branch June 25, 2025 17:51
This was referenced Jun 25, 2025
Closed
Closed
Closed
@gwr
Copy link
Contributor Author

gwr commented Jun 25, 2025

main branch gets staled on illumos over time because we don't have a CI leg (like runtime (Build freebsd-x64 Debug CoreCLR_Bootstrapped currently running on this PR), so it is a continuous maintenance thing;

Is there anything I could do to help get another CI leg in place for illumos?
Maybe an OmniOS instance in Azure or something? Thanks.

This was referenced Jun 25, 2025
Open
Open
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gwr @am11