Skip to content

JIT: Fix assert in object allocation phase #117066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

JIT: Fix assert in object allocation phase #117066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/coreclr/jit/objectalloc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4043,8 +4043,16 @@ bool ObjectAllocator::CheckCanClone(CloneInfo* info)
{
BasicBlock* const predBlock = predEdge->getSourceBlock();

// We may see unreachable pred blocks here. If so we will
// conservatively fail.
//
Copy link

Copilot AI Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The standalone // line adds noise without additional context. Consider removing it or merging it with adjacent comment lines for clarity.

Suggested change
//

Copilot uses AI. Check for mistakes.

if (!comp->m_dfsTree->Contains(predBlock))
{
JITDUMP("Unreachable pred block " FMT_BB " for " FMT_BB "\n", predBlock->bbNum, block->bbNum);
return false;
}

// We should not be able to reach an un-dominated block.
// (consider eh paths?)
//
assert(comp->m_domTree->Dominates(defBlock, predBlock));
if (BitVecOps::TryAddElemD(&traits, visitedBlocks, predBlock->bbID))
Expand Down
Loading