Add methods from #27912 (Flow System.Text.Rune through more APIs)#117168

Merged

tarekgh merged 207 commits intodotnet:mainfrom

Joy-less:rune-overloads

Sep 26, 2025

Commits on Jan 24, 2025

Add rune overloads
Joy-less
committed

Commits on Jan 25, 2025

Commits on Sep 1, 2025

Merge branch 'main' into rune-overloads
jeffhandley
authored

Commits on Sep 5, 2025

Commits on Sep 17, 2025

Commits on Sep 18, 2025

Commits on Sep 21, 2025

Commits on Sep 22, 2025

Commits on Sep 24, 2025

Commits on Sep 25, 2025

Some fixes and ensure the Runtime tests passes
tarekgh
committed
Merge branch 'rune-overloads' of https://github.com/Joy-less/runtime into rune-overloads
tarekgh
committed
Add brackets to ternary condition
Joy-less
committed
Rename `runeSeparator` to `separatorSpan`
Joy-less
committed
Add rune overloads

Joy-less
authored and
tarekgh
committed
Fix some compiler errors

Joy-less
authored and
tarekgh
committed
More compiler error fixes

Joy-less
authored and
tarekgh
committed
Even more compiler error fixes

Joy-less
authored and
tarekgh
committed
Fix more compiler errors

Joy-less
authored and
tarekgh
committed
Various improvements & add refs

Joy-less
authored and
tarekgh
committed
Fix validation in LastIndexOf

authored and
tarekgh
committed
Fix replace core usage

Joy-less
authored and
tarekgh
committed
Fix TextInfo ToLower/ToUpper with 2-char runes

Joy-less
authored and
tarekgh
committed
Optimize `char.Equals` for Ordinal StringComparison

Joy-less
authored and
tarekgh
committed
Add conditional compilation for SYSTEM_PRIVATE_CORLIB

Joy-less
authored and
tarekgh
committed
Add more conditional compilation for SYSTEM_PRIVATE_CORLIB

Joy-less
authored and
tarekgh
committed
Rename `r` to `value`

Joy-less
authored and
tarekgh
committed
Replace static Equals with instance methods

Joy-less
authored and
tarekgh
committed
Rename `r` to `value` in refs

Joy-less
authored and
tarekgh
committed
Fix ToLower & ToUpper bypassing invariant globalization check

Joy-less
authored and
tarekgh
committed
Add newline between ToLower, ToUpper

Joy-less
authored and
tarekgh
committed
Optimize TextWriter.Write(Rune)

Joy-less
authored and
tarekgh
committed
Optimize TextWriter.WriteLine(Rune)

Joy-less
authored and
tarekgh
committed
Change TextWriter.WriteAsync(Rune)

Joy-less
authored and
tarekgh
committed
Change TextWriter.WriteLineAsync(Rune)

Joy-less
authored and
tarekgh
committed
Remove unnecessary slices in ToLower(Rune) & ToUpper(Rune)

Joy-less
authored and
tarekgh
committed
Revert `Split(char, options)`, `Split(char, int, options)` order

Joy-less
authored and
tarekgh
committed
Flip Split(Rune, options) and Split(Rune, int, options) order

Joy-less
authored and
tarekgh
committed
Make `Equals(char, StringComparison)` helper internal

Joy-less
authored and
tarekgh
committed
Add `StringBuilder.EnumerateRunes()` & `StringBuilder.RuneEnumerator`

Joy-less
authored and
tarekgh
committed
Make `IndexOf`/`LastIndexOf` overload helpers internal

Joy-less
authored and
tarekgh
committed
Fix WriteLineAsync(Rune)

Joy-less
authored and
tarekgh
committed
Rename left/right local variables to old/new

Joy-less
authored and
tarekgh
committed
Remove unnecessary `else`

Joy-less
authored and
tarekgh
committed
Move StringBuilder.RuneEnumerator -> StringBuilderRuneEnumerator

Joy-less
authored and
tarekgh
committed
Add `ArgumentOutOfRangeException.ThrowIfNegative(index);`

Joy-less
authored and
tarekgh
committed
Replace exception with ThrowHelper.ThrowIndexOutOfRangeException();

Joy-less
authored and
tarekgh
committed
Add empty line between StringBuilder.Replace overloads

Joy-less
authored and
tarekgh
committed
Add doc comments to all added APIs

Joy-less
authored and
tarekgh
committed
Use invariant culture for string.Replace(Rune, Rune)

Joy-less
authored and
tarekgh
committed
Reference `StringBuilderRuneEnumerator.cs` file

Joy-less
authored and
tarekgh
committed
Update exceptions in string builder GetRuneAt

Joy-less
authored and
tarekgh
committed
Change string.Replace(Rune, Rune) compare options from None to Ordinal

Joy-less
authored and
tarekgh
committed
Use span comparison for StartsWith/EndsWith

Joy-less
authored and
tarekgh
committed
Make sure start index not bypassed in string.Trim(Rune)

Joy-less
authored and
tarekgh
committed
Fix incorrect slice end index

Joy-less
authored and
tarekgh
committed
Replace IndexOf & LastIndexOf code with span conversion

Joy-less
authored and
tarekgh
committed
Add `Contains_Rune` and `Contains_Rune_StringComparison` tests

Joy-less
authored and
tarekgh
committed
Add string.Split tests

Joy-less
authored and
tarekgh
committed
Add string.IndexOf & string.LastIndexOf tests

Joy-less
authored and
tarekgh
committed
Add string.Replace tests

Joy-less
authored and
tarekgh
committed
Fix string.Replace tests

Joy-less
authored and
tarekgh
committed
Add string.EndsWith tests

Joy-less
authored and
tarekgh
committed
Add string.StartsWith tests

Joy-less
authored and
tarekgh
committed
Fix bounds check in TrimStart(Rune)

Joy-less
authored and
tarekgh
committed
Fix bounds check in Trim(Rune)

Joy-less
authored and
tarekgh
committed
Simplify string.Empty to Empty

Joy-less
authored and
tarekgh
committed
Use AsSpan helper method to simplify rune to span

Joy-less
authored and
tarekgh
committed
Document ordinal comparisons

Joy-less
authored and
tarekgh
committed
Fix IndexOf/LastIndexOf startIndex

Joy-less
authored and
tarekgh
committed
Add Trim Rune tests

Joy-less
authored and
tarekgh
committed
Add StringBuilder test to EnumerateRunes test

Joy-less
authored and
tarekgh
committed
Separate EnumerateRunes tests for string & StringBuilder

Joy-less
authored and
tarekgh
committed
Add Rune.Equals(Rune, StringComparison) test

Joy-less
authored and
tarekgh
committed
Add StringBuilder Append Rune test

Joy-less
authored and
tarekgh
committed
Add StringBuilder GetRuneAt/TryGetRuneAt tests

Joy-less
authored and
tarekgh
committed
Add StringBuilder Insert_Rune and Insert_Rune_Invalid tests

Joy-less
authored and
tarekgh
committed
Use consistent style with other tests

Joy-less
authored and
tarekgh
committed
Add StringBuilder ReplaceRune tests

Joy-less
authored and
tarekgh
committed
Add TextWriter rune tests

Joy-less
authored and
tarekgh
committed
Add TextInfo ToLower/ToUpper tests

Joy-less
authored and
tarekgh
committed
Add rune tests to SplitCharSeparator

Joy-less
authored and
tarekgh
committed
Fix sub index not offsetted in IndexOf/LastIndexOf

Joy-less
authored and
tarekgh
committed
Fix LastIndexOf searchIndex

Joy-less
authored and
tarekgh
committed
Fix LastIndexOf

Joy-less
authored and
tarekgh
committed
Remove `#if SYSTEM_PRIVATE_CORLIB`

Joy-less
authored and
tarekgh
committed
Change code style for rune trimming

Joy-less
authored and
tarekgh
committed
Fix error in new code style

Joy-less
authored and
tarekgh
committed
Fix `Rune` not found in `TextInfoTests.cs`

Joy-less
authored and
tarekgh
committed
Fix incorrect method name in `TextWriterTests`

Joy-less
authored and
tarekgh
committed
Fix incorrect StartsWith Rune test

Joy-less
authored and
tarekgh
committed
Fix tests with Rune attribute arguments

Joy-less
authored and
tarekgh
committed
Fix `str` -> `value`

Joy-less
authored and
tarekgh
committed
Fix concatenating rune array

Joy-less
authored and
tarekgh
committed
Add dedicated `SplitRuneSeparator` test

Joy-less
authored and
tarekgh
committed
Fix trim rune tests

Joy-less
authored and
tarekgh
committed
Fix invalid collection expressions in tests

Joy-less
authored and
tarekgh
committed
Fix InsertRune test

Joy-less
authored and
tarekgh
committed
Fix replace rune tests

Joy-less
authored and
tarekgh
committed
Fix unused comparisonType parameter

Joy-less
authored and
tarekgh
committed
Fix index of test names

Joy-less
authored and
tarekgh
committed
Remove redundant test

Joy-less
authored and
tarekgh
committed
Fix missing using

Joy-less
authored and
tarekgh
committed
Fix replace method called with string comparison argument

Joy-less
authored and
tarekgh
committed
Fix tried to test split with rune on span

Joy-less
authored and
tarekgh
committed
Remove start index from LastIndexOf tests

Joy-less
authored and
tarekgh
committed
Remove non-existent comparisonType parameter

Joy-less
authored and
tarekgh
committed
Fix StartsWith test incorrect call

Joy-less
authored and
tarekgh
committed
Fix LastIndexOf behaviour

Joy-less
authored and
tarekgh
committed
Various rune test fixes

Joy-less
authored and
tarekgh
committed
Some fixes and ensure the Runtime tests passes
tarekgh
committed
Add brackets to ternary condition

Joy-less
authored and
tarekgh
committed
Rename `runeSeparator` to `separatorSpan`

Joy-less
authored and
tarekgh
committed
Final fixes touches.
tarekgh
committed
Merge branch 'rune-overloads' of https://github.com/Joy-less/runtime into rune-overloads
tarekgh
committed
Merge branch 'main' into rune-overloads
tarekgh
authored
Merge branch 'main' of https://github.com/dotnet/runtime into rune-overloads
tarekgh
committed
Merge branch 'rune-overloads' of https://github.com/Joy-less/runtime into rune-overloads
tarekgh
committed

Add methods from #27912 (Flow System.Text.Rune through more APIs)#117168tarekgh merged 207 commits intodotnet:maindotnet/runtime:mainfrom Joy-less:rune-overloadsJoy-less/runtime:rune-overloadsCopy head branch name to clipboard

Commits

Commits on Jan 24, 2025

Commits on Jan 25, 2025

Commits on Jun 30, 2025

Commits on Sep 1, 2025

Commits on Sep 5, 2025

Commits on Sep 17, 2025

Commits on Sep 18, 2025

Commits on Sep 19, 2025

Commits on Sep 20, 2025

Commits on Sep 21, 2025

Commits on Sep 22, 2025

Commits on Sep 23, 2025

Commits on Sep 24, 2025

Commits on Sep 25, 2025

Add methods from #27912 (Flow System.Text.Rune through more APIs)#117168
tarekgh merged 207 commits intodotnet:mainfrom
Joy-less:rune-overloads