Skip to content

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jun 30, 2025

Fixes #117146

image

@ViktorHofer ViktorHofer requested review from Copilot and wtgodbe June 30, 2025 18:25
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 30, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures the System.Security.Cryptography.Pkcs assembly for the net10.0-windows TFM is included in the ASP.NET Core transport pack.

  • Adds System.Security.Cryptography.Pkcs to the shared framework props so it’s available in .NET 10.
  • References the Pkcs project with a windows-specific TFM and wires it into the transport pack MSBuild logic.
  • Adjusts path separators in packaging.targets to flatten package and symbol output paths.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/libraries/NetCoreAppLibrary.props Added System.Security.Cryptography.Pkcs to the list of included shared framework assemblies
src/libraries/Microsoft.Internal.Runtime.AspNetCore.Transport/src/Microsoft.Internal.Runtime.AspNetCore.Transport.proj Added a windows-targeted Pkcs ProjectReference and a custom target to surface it
eng/packaging.targets Switched to forward slashes and removed redundant separators in package/symbol paths
Comments suppressed due to low confidence (3)

src/libraries/Microsoft.Internal.Runtime.AspNetCore.Transport/src/Microsoft.Internal.Runtime.AspNetCore.Transport.proj:40

  • Consider adding an integration or packaging test to verify that the Pkcs DLL and its PDB actually end up in the runtimes/win/lib/$(NetCoreAppCurrent) folder of the generated ASP.NET Core transport package.
    <ProjectReference Include="$(LibrariesProjectRoot)System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj"

eng/packaging.targets:253

  • Mixing forward slashes and backslashes in MSBuild paths can lead to inconsistent output on Windows. Consider using $(BuildOutputTargetFolder)\$(_referringTargetFramework)\ or normalizing separators uniformly.
                              PackagePath="$([MSBuild]::ValueOrDefault('%(ReferenceCopyLocalPaths.PackagePath)', '$(BuildOutputTargetFolder)/$(_referringTargetFramework)/'))" />

eng/packaging.targets:255

  • This relies on PackagePath ending with a slash. If it doesn't, output paths may run together. You might add a slash in the metadata or use TrimEnd('\/') and then append a single separator.
                                   TargetPath="/%(TfmSpecificPackageFile.PackagePath)%(Filename)%(Extension)"

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViktorHofer
Copy link
Member Author

/ba-g failures are unrelated

@ViktorHofer ViktorHofer merged commit 3f1943e into main Jul 1, 2025
145 of 153 checks passed
@ViktorHofer ViktorHofer deleted the IncludePkcsAndPkcsWindowsInTransportPack branch July 1, 2025 12:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include Pkcs (net10.0 & net10.0-windows) assemblies in aspnetcore transport pack

2 participants