[clr-interp] Implement intrinsics for startup path #117263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
kotlarmilos
added
area-CodeGen-Interpreter-coreclr
and removed
needs-area-label
kotlarmilos
added
the
NO-MERGE
…armilos/runtime into feature/coreclr-interp-startup-path
kotlarmilos
commented
Jul 9, 2025
kotlarmilos
commented
Jul 9, 2025
This was referenced Jul 9, 2025
kotlarmilos
removed
the
NO-MERGE
kg
reviewed
Jul 10, 2025
kg
reviewed
Jul 10, 2025
kg
reviewed
Jul 10, 2025
|
other than my comments and jan's, LGTM, thanks! |
jkotas
reviewed
Jul 10, 2025
- Updated EmitNamedIntrinsicCall to include emitMemBarrier parameter. - Replaced INTOP_METHODTABLE with INTOP_GETMETHODTABLE in EmitNamedIntrinsicCall - Introduced INTOP_NULLCHECK operation in intops.def and implemented its handling in the interpreter - Removed debug print statements from compileMethod - Added tests
jkotas
reviewed
Jul 10, 2025
jkotas
reviewed
Jul 10, 2025
jkotas
reviewed
Jul 13, 2025
12 tasks
|
/ba-g android timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal is to identify and implement additional missing intrinsics used during startup.
This PR implements missing intrinsics for the startup path. It builds on changes from #116769 and #116924 which fixed conv opcodes and introduced scaffolding for intrinsic handling. This PR is a follow-up to mentioned PRs and will not be merged until those are merged.
Changes
Tasks
Run a sample desktop app using the following environment variables: