Skip to content

[HTTP] H/3 fix test closing server connection prematurely #117458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

[HTTP] H/3 fix test closing server connection prematurely #117458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
923ccac
Add synchronization into the test
ManickaP Jul 9, 2025
6a8f216
Feedback
ManickaP Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2173,6 +2173,7 @@ public async Task SendAsync_InvalidRequestUri_Throws()
public async Task SendAsync_RequestWithDangerousControlHeaderValue_ThrowsHttpRequestException(char dangerousChar, HeaderType headerType)
{
TaskCompletionSource<bool> acceptConnection = new TaskCompletionSource<bool>();
SemaphoreSlim clientFinished = new SemaphoreSlim(0);

await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
{
Expand Down Expand Up @@ -2216,6 +2217,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
// WinHTTP validates the input before opening connection whereas SocketsHttpHandler opens connection first and validates only when writing to the wire.
acceptConnection.SetResult(!IsWinHttpHandler);
var ex = await Assert.ThrowsAnyAsync<Exception>(() => client.SendAsync(request));
clientFinished.Release();
var hrex = Assert.IsType<HttpRequestException>(ex);
if (IsWinHttpHandler)
{
Expand All @@ -2231,7 +2233,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
{
if (await acceptConnection.Task)
{
await IgnoreExceptions(server.AcceptConnectionAsync(c => Task.CompletedTask));
await IgnoreExceptions(() => server.AcceptConnectionAsync(_ => clientFinished.WaitAsync(TestHelper.PassingTestTimeout)));
}
});
}
Expand Down
Loading