[Android] InvariantGlobalization support for CoreCLR Android builds

[davidnguyen-tech]

Description

Forward the InvariantGlobalization MSBuild property to the CoreCLR runtime for Android applications by connecting the existing infrastructure.

Related issues

Fixes #117270

[Copilot]

Pull Request Overview

This PR enables passing the InvariantGlobalization MSBuild property through the Android build pipeline so that Android apps can opt into invariant globalization mode at runtime.

• Forwards the InvariantGlobalization property in test builds, Android build targets, and app tasks
• Exposes a new InvariantGlobalization property on AndroidAppBuilderTask and propagates it into ApkBuilder
• Removes the exclusion of the invariant globalization tests so they run against Android CoreCLR

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/tests/build.proj	Adds InvariantGlobalization to the test project invocation parameters
src/tasks/AndroidAppBuilder/ApkBuilder.cs	Injects DOTNET_SYSTEM_GLOBALIZATION_INVARIANT when InvariantGlobalization is true
src/tasks/AndroidAppBuilder/AndroidAppBuilder.cs	Declares InvariantGlobalization on the task and forwards it to ApkBuilder
src/mono/msbuild/android/build/AndroidBuild.targets	Passes the MSBuild InvariantGlobalization property to the Android build targets
src/libraries/tests.proj	Removes the exclusion for the invariant globalization tests

Comments suppressed due to low confidence (2)

src/tasks/AndroidAppBuilder/AndroidAppBuilder.cs:149

• There are no tests verifying that InvariantGlobalization flows through the task to the APK and sets the correct environment variable. Consider adding a unit or integration test to validate this behavior.

        apkBuilder.InvariantGlobalization = InvariantGlobalization;

src/tasks/AndroidAppBuilder/ApkBuilder.cs:427

• The InvariantGlobalization property is referenced here but the ApkBuilder class does not define it. Add a public bool InvariantGlobalization { get; set; } property to ApkBuilder to ensure this compiles.

        if (InvariantGlobalization)

[davidnguyen-tech]

@dotnet-policy-service agree company="Microsoft"

[dotnet-policy-service]

Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

[kotlarmilos]

/azp run runtime-android,runtime-androidemulator

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[kotlarmilos]

Let's check if the other globalization failures are resolved with this PR. Otherwise, LGTM!

[kotlarmilos]

/azp run runtime-android,runtime-androidemulator

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[davidnguyen-tech]

/azp run runtime-android,runtime-androidemulator

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[kotlarmilos]

LGTM!

[kotlarmilos]

/ba-g android emulators capacity problem

[akoeplinger]

@davidnguyen-tech @kotlarmilos does this mean coreclr doesn't read the runtimeconfig.json yet? cause it should be set there afaik.

[akoeplinger]

I just saw the discussion with @vitek-karas in #117542 (comment), I agree that passing this through EnvironmentVariables is better and we can get rid of the workaround once coreclr android supports reading runtimeconfig.json.

The InvariantGlobalization property on ApkBuilder looks like a leftover

[davidnguyen-tech]

@akoeplinger I agree - since it seems like nobody's using the property, I will refactor it to be passed through EnvironmentVariables and get rid of the property. Thanks for pointing it out!

[vitek-karas]

we can get rid of the workaround once coreclr android supports reading runtimeconfig.json

Just to clarify - the proper Android hosting from dotnet/android does support this already. The problem is with the simple test host we use in dotnet/runtime. We've discussed this with @davidnguyen-tech and it's probably not worth the effort yet to implement something in the simple test host.

[akoeplinger]

@vitek-karas hmm not sure I agree with that, there are likely other important settings you'll miss and all other hosts are implementing it.

I see that this is implemented in https://github.com/dotnet/android/blob/868acb2ceab4f97a5c261e8288500f2e3e2f8901/src/native/clr/host/host.cc#L33, can we not provide a simple implementation of get_runtime_property in dotnet/runtime? We already have the runtimeconfig.bin conversion code so you don't need to parse json.

[vitek-karas]

@akoeplinger - we were discussing exactly that. For this specific problem we don't need it, because the knob has an env. variable. I just wanted to "Wait" until we find a case where we do need a knob which doesn't have env. variable - and implement it then.
But if David wants to pick it up right now, it's likely not a throw away work.

[akoeplinger]

ok, makes sense

[davidnguyen-tech]

The runtimeconfig.json support for our test host is tracked in #117919.