Fix intermittent PerformanceCounter test failures due to file access conflicts

[Copilot]

This PR addresses intermittent test failures in System.Diagnostics.Tests.PerformanceCounterTests.PerformanceCounter_IncrementBy_IncrementByReadOnly and other performance counter tests that occur due to file access conflicts during category creation and deletion operations.

Root Cause

The tests were failing with:

System.ComponentModel.Win32Exception : The process cannot access the file because it is being used by another process.
   at System.Diagnostics.PerformanceCounterLib.RegisterFiles(String arg0, Boolean unregister)
   at System.Diagnostics.PerformanceCounterCategory.Delete(String categoryName)
   at System.Diagnostics.Tests.Helpers.DeleteCategory(String categoryName)

This error indicates file access conflicts, likely due to antivirus scanners or other processes temporarily accessing the performance counter files during test execution.

Solution

Enhanced the test helper methods with robust retry logic to handle transient file access issues:

1. Enhanced CreateCategory helper

• Wraps PerformanceCounterCategory.Create calls with RetryHelper.Execute
• Retries up to 10 times for retriable exceptions

2. Enhanced DeleteCategory helper

• Wraps PerformanceCounterCategory.Delete calls with RetryHelper.Execute
• Retries up to 10 times for retriable exceptions

3. Added intelligent exception filtering

• IsRetriableException method identifies specific exceptions that should trigger retries:
  • Win32Exception with error codes 32 (sharing violation), 5 (access denied), 33 (lock violation)
  • IOException for general file access issues
  • UnauthorizedAccessException for permission issues
• Non-retriable exceptions (like argument validation errors) are immediately propagated

4. Updated test cleanup

• Changed direct PerformanceCounterCategory.Delete calls in test files to use the retry-enabled Helpers.DeleteCategory method

Example of the fix in action

Before:

// This could fail with file access conflicts
PerformanceCounterCategory.Delete(categoryName);

After:

// This retries automatically on file access conflicts
RetryHelper.Execute(() =>
{
    PerformanceCounterCategory.Delete(categoryName);
}, maxAttempts: 10, retryWhen: IsRetriableException);

The retry logic follows the same pattern already established in the codebase with RetryOnAllPlatforms methods, ensuring consistency with existing test infrastructure.

Fixes #105925.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[ericstj]

@copilot please address this feedback.

[tarekgh]

LGTM!

[ericstj]

/ba-g Android tests timeout - not related, IO.Pipelines test dead-lettered - not touched in this PR.