Skip to content

JIT: Allow more containment opts in Tier0 #117622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025
Merged

JIT: Allow more containment opts in Tier0 #117622

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b042369
allow more containment opts in tier0
saucecontrol Jul 14, 2025
f0bef79
disable aligned load containment when opts disabled
saucecontrol Jul 15, 2025
e16f00e
revert TryFoldCnsVecForEmbeddedBroadcast changes
saucecontrol Jul 16, 2025
00a3644
Merge branch 'main' into more-t0-opts
tannergooding Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/coreclr/jit/lowerxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9255,15 +9255,15 @@ bool Lowering::IsContainableHWIntrinsicOp(GenTreeHWIntrinsic* parentNode, GenTre
case NI_AVX_LoadAlignedVector256:
case NI_AVX512_LoadAlignedVector512:
{
// In minOpts, we need to ensure that an unaligned address will fault when an explicit LoadAligned is used.
// Non-VEX encoded instructions will fault if an unaligned SIMD16 load is contained but will not for scalar
// loads, and VEX-encoded instructions will not fault for unaligned loads in any case.
// For debug code, we need to ensure that an unaligned address will fault when an explicit LoadAligned is
// used. Non-VEX encoded instructions will fault if an unaligned SIMD16 load is contained but will not for
// scalar loads, and VEX-encoded instructions will not fault for unaligned loads in any case.
//
// When optimizations are enabled, we want to contain any aligned load that is large enough for the parent's
// requirement.

return (supportsSIMDLoad &&
((!comp->canUseVexEncoding() && expectedSize == genTypeSize(TYP_SIMD16)) || !comp->opts.MinOpts()));
return (supportsSIMDLoad && (comp->opts.OptimizationEnabled() ||
(!comp->canUseVexEncoding() && expectedSize == genTypeSize(TYP_SIMD16))));
}

case NI_X86Base_LoadScalarVector128:
Expand All @@ -9279,7 +9279,7 @@ bool Lowering::IsContainableHWIntrinsicOp(GenTreeHWIntrinsic* parentNode, GenTre
case NI_AVX2_BroadcastScalarToVector256:
case NI_AVX512_BroadcastScalarToVector512:
{
if (comp->opts.MinOpts() || !comp->canUseEmbeddedBroadcast())
if (!comp->opts.Tier0OptimizationEnabled() || !comp->canUseEmbeddedBroadcast())
{
return false;
}
Expand Down
Loading