-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Make Pkcs12LoaderLimits.AllowDuplicateAttributes public #117674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes the AllowDuplicateAttributes
property of the Pkcs12LoaderLimits
class public, addressing issue #117516. This change provides users with more granular control over PKCS#12 loading behavior without requiring them to use the DangerousNoLimits
setting.
Key changes:
- Exposed the
AllowDuplicateAttributes
property as public API - Updated test code to use the newly public property instead of relying on
DangerousNoLimits
- Added the property to the reference assembly
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs |
Added public AllowDuplicateAttributes property to the reference assembly |
src/libraries/Common/src/System/Security/Cryptography/X509Certificates/Pkcs12LoaderLimits.cs |
Changed visibility of AllowDuplicateAttributes property from internal to public |
src/libraries/Common/tests/System/Security/Cryptography/X509Certificates/X509CertificateLoaderPkcs12Tests.cs |
Updated test to use the public property directly instead of conditional logic with DangerousNoLimits |
src/libraries/Common/tests/System/Security/Cryptography/X509Certificates/X509CertificateLoaderPkcs12CollectionTests.cs |
Updated test to use the public property directly instead of conditional logic with DangerousNoLimits |
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
.../System/Security/Cryptography/X509Certificates/X509CertificateLoaderPkcs12CollectionTests.cs
Show resolved
Hide resolved
@bartonjs I don't think we can OOB this for < .NET 10. Since the loader limit is a type forward for .NET 9, we can't make it public in the .NET 9 build but have it type forward to in in-box one that is still internal. |
Good catch on the OOB. |
/ba-g Android time out is dotnet/dnceng#5909. The lane was disabled in #117703 but this pull request was in between the known issue and the lane getting disabled. |
Closes #117516