Skip to content

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Jul 15, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 15, 2025 19:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the DB_IPCE_LOAD_ASSEMBLY event mechanism from the CoreCLR debugger interface. The change consolidates assembly loading notifications by moving the assembly loading callback functionality into the existing module loading event handling instead of maintaining a separate assembly loading event.

Key changes:

  • Removes the separate DB_IPCE_LOAD_ASSEMBLY event type and associated infrastructure
  • Moves assembly loading callback invocation to occur during DB_IPCE_LOAD_MODULE event processing
  • Updates assembly notification logic to use module load flags instead of assembly load flags

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/coreclr/vm/dbginterface.h Removes LoadAssembly virtual method declaration from DebugInterface
src/coreclr/vm/assembly.cpp Changes assembly loading to use MODULE_LOAD flag and removes assembly-specific notification logic
src/coreclr/vm/appdomain.hpp Removes ATTACH_ASSEMBLY_LOAD enum constant
src/coreclr/debug/ee/debugger.h Removes LoadAssembly method declaration from Debugger class
src/coreclr/debug/ee/debugger.cpp Removes entire LoadAssembly method implementation
src/coreclr/debug/di/process.cpp Moves assembly loading callback from DB_IPCE_LOAD_ASSEMBLY case to DB_IPCE_LOAD_MODULE case

Copy link
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@thaystg thaystg requested review from steveisok and tommcdon July 15, 2025 20:22
@thaystg
Copy link
Member Author

thaystg commented Jul 16, 2025

/ba-g failures are unrelated

@thaystg thaystg merged commit d71c87f into dotnet:main Jul 16, 2025
96 of 98 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants