Skip to content

Delete unused corpublish support and multi appdomain support in the debugger #117688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 21, 2025
Merged

Delete unused corpublish support and multi appdomain support in the debugger #117688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c40631b
Delete unused corpublish support
jkoritzinsky Jul 15, 2025
54aba51
Simplify debugger handling for appdomains as we always have only one.
jkoritzinsky Jul 15, 2025
0efa45d
Update comment
jkoritzinsky Jul 15, 2025
eeba780
Remove unused assignment
jkoritzinsky Jul 15, 2025
4b4089e
Merge branch 'main' into delete-dead-code
jkoritzinsky Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/coreclr/debug/di/cordb.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,9 @@
//-----------------------------------------------------------------------------
// In v1.0, we declared that mscordbi was a "shared" component, which means
// that we promised to provide it from now until the end of time. So every CLR implementation
// needs an Mscordbi that implements the everett guids for CorDebug + CorPublish.
// needs an Mscordbi that implements the everett guids for CorDebug
//
// This works fine for CorPublish, which is truly shared.
// CorDebug however is "versioned" not "shared" - each version of the CLR has its own disjoint copy.
// CorDebug is "versioned" not "shared" - each version of the CLR has its own disjoint copy.
//
// Thus creating a CorDebug object requires a version parameter.
// CoCreateInstance doesn't have a the version param, so we use the new (v2.0+)
Expand Down Expand Up @@ -307,14 +306,6 @@ STDAPI DLLEXPORT DllGetClassObjectInternal( // Return code.
CClassFactory *pClassFactory; // To create class factory object.
PFN_CREATE_OBJ pfnCreateObject = NULL;


#if defined(FEATURE_DBG_PUBLISH)
if (rclsid == CLSID_CorpubPublish)
{
pfnCreateObject = CorpubPublish::CreateObject;
}
else
#endif
#if defined(FEATURE_DBGIPC_TRANSPORT_DI)
if (rclsid == CLSID_CorDebug_Telesto)
{
Expand Down
Loading
Loading