Skip to content

arm64: Add Sve2 Saturating functions #117758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

arm64: Add Sve2 Saturating functions #117758

merged 1 commit into from
Jul 18, 2025

Conversation

jonathandavies-arm
Copy link
Contributor

@jonathandavies-arm jonathandavies-arm commented Jul 17, 2025 •
edited
Loading

  • Implements Arm64: Implement SVE2 APIs #115479
  • In the Sve2 Maths API it has MultiplyDoublingWideningAndSubtractSaturateOdd with and without the index argument. In all the other cases the index case has a function name with BySelectedScalar in it. I've added the function MultiplyDoublingWideningBySelectedScalarAndAddSaturateEven to be consistent with the other functions.

@jonathandavies-arm
arm64: Add Sve2 Saturating functions
9160bec 
* Implements dotnet#115479
* In the Sve2 Maths API it has MultiplyDoublingWideningAndSubtractSaturateOdd with and without the index argument. In all the other cases the index case has a function name with BySelectedScalar in it. I've added the function MultiplyDoublingWideningBySelectedScalarAndAddSaturateEven to be consistant with the other functions.
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 17, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 17, 2025
@jonathandavies-arm
Copy link
Contributor Author

@dotnet/arm64-contrib @amanasifkhalid

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@a74nh a74nh mentioned this pull request Jul 17, 2025
Open
amanasifkhalid
amanasifkhalid approved these changes Jul 17, 2025
View reviewed changes
This was referenced Jul 17, 2025
Closed
Open
Closed
@amanasifkhalid
Copy link
Contributor

I'm going to merge this now so we can meet the P7 deadline. My only feedback was a question about the emitter tests.

@amanasifkhalid
Copy link
Contributor

/ba-g build timeouts

@amanasifkhalid amanasifkhalid merged commit de52942 into dotnet:main Jul 18, 2025
160 of 167 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@amanasifkhalid amanasifkhalid amanasifkhalid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathandavies-arm @amanasifkhalid