Fix ILLink ref assembly build breaks #117875
Conversation
This is blocking dotnet/dotnet#1546. Looks like this got lost in all the WASM timeout noise in dotnet#117624. We can either suppress or add to ref assembly, but ref assembly only has things ILLink custom steps depend on. So suppression it is. I just regenerated it with `/p:ApiCompatGenerateSuppressionFile=true` so it shuffled two unrelated lines.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ILLink reference assembly build breaks by adding necessary API compatibility suppressions. The changes prevent build failures that were blocking dependent PRs.
Key changes:
- Added suppressions for
GetEntryPointAssemblyandSetEntryPointAssemblymethods inAnnotationStore - Added suppressions for
DisableGeneratedCodeHeuristicsproperty getter and setter inLinkContext - Reorganized existing suppressions to maintain alphabetical ordering
github-actions
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @dotnet/illink |
|
/ba-g timeouts |
|
Thanks @MichalStrehovsky! |
|
Do you actually need/want a reference assembly for illink? If not you could disable that. It's silly to just baseline stuff if you don't actually need the reference assembly. |
|
Yes, the ref assembly is used to expose the API surface that custom steps can use. |
|
/backport to release/10.0-preview7 Submitting this for Preview 7 backport since every PR in the release branch will hit this otherwise. |
|
Started backporting to release/10.0-preview7: https://github.com/dotnet/runtime/actions/runs/16435351174 |
5 participants
This is blocking dotnet/dotnet#1546. Looks like this got lost in all the WASM timeout noise in #117624.
We can either suppress or add to ref assembly, but ref assembly only has things ILLink custom steps depend on. So suppression it is.
I just regenerated it with
/p:ApiCompatGenerateSuppressionFile=trueso it shuffled two unrelated lines.Cc @dotnet/illink