Skip to content

Conversation

max-charlamb
Copy link
Member

@max-charlamb max-charlamb commented Jul 24, 2025

Modifies EnumMethodInstancesByAddress to only return a single IXCLRDataMethodInstance representing the instance at the given IP address.

Running diagnostics tests on new behavior

@Copilot Copilot AI review requested due to automatic review settings July 24, 2025 19:18
@max-charlamb
Copy link
Member Author

/azp run runtime-diagnostics

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the EnumMethodInstancesByAddress behavior to return only a single IXCLRDataMethodInstance representing the method instance at the given IP address, rather than enumerating through multiple instances.

Key changes:

  • Simplified enumeration logic to return at most one method instance
  • Moved native code check from iterator to the start enumeration function
  • Replaced iterator-based approach with a single completion flag

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/coreclr/debug/daccess/task.cpp Simplified EnumMethodInstances::Next() to return single instance and moved native code validation to StartEnumMethodInstancesByAddress()
src/coreclr/debug/daccess/dacimpl.h Replaced iterator fields with simple completion flag in EnumMethodInstances class
src/coreclr/debug/daccess/daccess.cpp Added native code check in StartEnumMethodInstancesByAddress() before starting enumeration

Copy link
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant