Don't use vfork on android #118085
Merged
Don't use vfork on android #118085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we start the child process, we clear all signal handlers. This operations ends up clearing the signal handlers also for the parent process. Revert to just using fork for simplicity.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a signal handling issue on Android by reverting from vfork() to fork() for process creation. The issue occurs because Android's vfork() implementation shares signal handlers between parent and child processes, causing the parent's signal handlers to be incorrectly cleared when the child process resets its handlers during startup.
Key Changes:
- Excludes Android from using
vfork()in process creation - Updates comments to explain the Android-specific signal handling issue
- Maintains existing exclusions for Apple platforms
github-actions
bot
added
the
needs-area-label
BrzVlad
added
area-System.Diagnostics.Process
and removed
needs-area-label
|
cc @janvorli |
simonrozsival
approved these changes
Jul 28, 2025
|
/ba-g wasm failures unrelated |
|
I think this could be a candidate for backport to net9 |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/16721026186 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we start the child process, we clear all signal handlers. When using vfork, on Android, this operation ends up clearing the signal handlers also for the parent process. Revert to just using fork for simplicity.
vfork usage was added back in dotnet/corefx#33289, seems like there were some potential concerns then.
Legacy Xamarin was using fork.
Fixes #97209.