Fix -msbuild build for Clr subset #118206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build issue with the -msbuild build for the CLR subset by addressing a CMake compatibility problem with Visual Studio generators. The change ensures that the EXCLUDE_FROM_ALL property is only set for non-Visual Studio generators to prevent build failures.
Key Changes:
- Adds conditional logic to prevent setting
EXCLUDE_FROM_ALLproperty when using Visual Studio generators
github-actions
bot
added
the
needs-area-label
jkoritzinsky
approved these changes
Jul 31, 2025
kotlarmilos
approved these changes
Jul 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118093