Skip to content

[release/9.0-staging] Don't use vfork on android #118331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: [manual] Merge release/9.0-staging into release/9.0
merged 2 commits into from
Sep 4, 2025
Merged

[release/9.0-staging] Don't use vfork on android #118331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
026d9c6
Don't use vfork on android
BrzVlad Jul 26, 2025
b665c53
Merge branch 'release/9.0-staging' into backport/pr-118085-to-release…
steveisok Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/native/libs/System.Native/pal_process.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,11 @@ int32_t SystemNative_ForkAndExecProcess(const char* filename,
sigfillset(&signal_set);
pthread_sigmask(SIG_SETMASK, &signal_set, &old_signal_set);

#if HAVE_VFORK && !(defined(__APPLE__)) // We don't trust vfork on OS X right now.
// vfork on OS X is deprecated
// On Android, signal handlers between parent and child processes are shared with vfork, so when we reset
// the signal handlers during child startup, we end up incorrectly clearing also the ones for the parent.
#if HAVE_VFORK && !defined(__APPLE__) && !defined(TARGET_ANDROID)

// This platform has vfork(). vfork() is either a synonym for fork or provides shared memory
// semantics. For a one gigabyte process, the expected performance gain of using shared memory
// vfork() rather than fork() is 99.5% merely due to avoiding page faults as the kernel does not
Expand Down
Loading