Skip to content

Conversation

tomeksowi
Copy link
Member

@tomeksowi tomeksowi commented Aug 11, 2025

Fallback to the library version, the generated version returned the lesser/greater magnitude instead of the original argument with such.

Also adjust Min/Max(Number) routines to adhere to new NaN requirements in #119897

Part of #84834, cc @dotnet/samsung

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 11, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 11, 2025
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tomeksowi
Copy link
Member Author

@risc-vv /run

@risc-vv
Copy link

risc-vv commented Aug 11, 2025

RISC-V pull_request-CLR-QEMU: 9101 / 9131 (99.67%)
=======================
      passed: 9101
      failed: 2
     skipped: 591
      killed: 28
------------------------
 TOTAL tests: 9722
VIRTUAL time: 80h 42min 24s 237ms
   REAL time: 1h 19min 1s 481ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V pull_request-CLR-VF2: 9101 / 9131 (99.67%)
=======================
      passed: 9101
      failed: 2
     skipped: 591
      killed: 28
------------------------
 TOTAL tests: 9722
VIRTUAL time: 32h 0min 35s 150ms
   REAL time: 2h 7min 10s 321ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V pull_request-FX-QEMU: 0 / 1 (0.00%)
=======================
      passed: 0
      failed: 0
     skipped: 14
      killed: 1
------------------------
 TOTAL tests: 15
VIRTUAL time: 15s 444ms
   REAL time: 4h 30min 0s 487ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V pull_request-FX-VF2: 0 / 66 (0.00%)
=======================
      passed: 0
      failed: 0
     skipped: 14
      killed: 66
------------------------
 TOTAL tests: 80
VIRTUAL time: 1min 14s 522ms
   REAL time: 12h 30min 7s 384ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 0d012b4d1be3ca4ebd5e3600f19920d644db105b
CI: d023c7d591ab286aa343d644f00b5daa59d8d6b0
REPO: dotnet/runtime
BRANCH: main
CONFIG: Checked
LIB_CONFIG: Release

@JulieLeeMSFT
Copy link
Member

@tannergooding and @jakobbotsch, please review this PR.

@tannergooding
Copy link
Member

Thanks! Will let @jakobbotsch give it another pass as well, but I think this looks good to merge

@jakobbotsch jakobbotsch merged commit 2fb5cb1 into dotnet:main Oct 2, 2025
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants