-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[RISC-V] De-intrinsify Min/MaxMagnitude #118589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
@risc-vv /run |
RISC-V pull_request-CLR-QEMU: 9101 / 9131 (99.67%)
report.xml, report.md, failures.xml, testclr_details.tar.zst RISC-V pull_request-CLR-VF2: 9101 / 9131 (99.67%)
report.xml, report.md, failures.xml, testclr_details.tar.zst RISC-V pull_request-FX-QEMU: 0 / 1 (0.00%)
report.xml, report.md, failures.xml, testclr_details.tar.zst RISC-V pull_request-FX-VF2: 0 / 66 (0.00%)
report.xml, report.md, failures.xml, testclr_details.tar.zst Build information and commandsGIT: |
@tannergooding and @jakobbotsch, please review this PR. |
Thanks! Will let @jakobbotsch give it another pass as well, but I think this looks good to merge |
Fallback to the library version, the generated version returned the lesser/greater magnitude instead of the original argument with such.
Also adjust
Min/Max(Number)
routines to adhere to new NaN requirements in #119897Part of #84834, cc @dotnet/samsung