Skip to content

Fix assert in IsKnownConstant importation #118634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2025
Merged

Fix assert in IsKnownConstant importation #118634

merged 2 commits into from
Aug 14, 2025

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 12, 2025

The repro shared in the community discord: https://godbolt.org/z/M4d8EKnT6 failed with

Assertion failed '(*use)->WasMorphed()' in 'C:Main(System.String[])' during 'Morph - Global' (IL size 22; hash 0x6458c5ee; FullOpts)

because gtNewIconNode(0) was not marked as morphed.

@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 12:25
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 12, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot
Copilot AI reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

This was referenced Aug 12, 2025
Closed
Closed
@EgorBo
Copy link
Member Author

EgorBo commented Aug 13, 2025

PTAL @dotnet/jit-contrib fixes a small assert

This was referenced Aug 14, 2025
Closed
Open
Closed
Closed
@EgorBo EgorBo merged commit 953f308 into dotnet:main Aug 14, 2025
104 of 107 checks passed
@EgorBo EgorBo deleted the fix-isknownconstant-assert branch August 14, 2025 12:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@EgorBo EgorBo

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo @AndyAyersMS