Skip to content

Comments

JIT: Do not remove type changing casts in lowering optimization#118636

Merged
jakobbotsch merged 1 commit intodotnet:mainfrom
jakobbotsch:fix-118596
Aug 13, 2025
Merged

JIT: Do not remove type changing casts in lowering optimization#118636
jakobbotsch merged 1 commit intodotnet:mainfrom
jakobbotsch:fix-118596

Conversation

@jakobbotsch
Copy link
Member

Fix #118596

Hopefully last fix to these conditions...

Copilot AI review requested due to automatic review settings August 12, 2025 13:20
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 12, 2025
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @EgorBo

Another regression from my change in #118345...

@jakobbotsch jakobbotsch requested a review from EgorBo August 12, 2025 13:20
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jakobbotsch jakobbotsch merged commit ed9a505 into dotnet:main Aug 13, 2025
104 of 108 checks passed
@jakobbotsch jakobbotsch deleted the fix-118596 branch August 13, 2025 11:59
@tomeksowi
Copy link
Member

Thanks, I was about to push my own fix but this also does the trick.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JIT: wrong results in some async tests under jitstress

3 participants