Skip to content

NOOP change in Mono to run tests #118642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VSadov wants to merge 3 commits into from
Closed

NOOP change in Mono to run tests #118642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43a677f
NOOP change to run tests
VSadov Aug 12, 2025
75604df
touch aot-compiler
VSadov Aug 12, 2025
a4cf8a5
touch gc.c and ILLink.Descriptors.xml
VSadov Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mono/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@

<!-- domain.c: mono_defaults.object_class -->
<type fullname="System.Object">
<!-- class.c: initialize_object_slots -->
<!-- class.c: initialize_object_slots -->
<method name="Finalize" />
<method name="GetHashCode" />
</type>
Expand Down
1 change: 1 addition & 0 deletions src/mono/System.Private.CoreLib/src/System/Object.Mono.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ namespace System
{
public partial class Object
{
// NOOP comment change
[Intrinsic]
public Type GetType() => GetType();

Expand Down
2 changes: 1 addition & 1 deletion src/mono/mono/metadata/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ mono_gc_run_finalize (void *obj, void *data)
/*
* To avoid the locking plus the other overhead of mono_runtime_invoke_checked (),
* create and precompile a wrapper which calls the finalize method using
* a CALLVIRT.
* a CALLVIRT
*/
if (mono_log_finalizers)
g_log ("mono-gc-finalizers", G_LOG_LEVEL_MESSAGE, "<%s at %p> Compiling finalizer.", o_name, o);
Expand Down
2 changes: 1 addition & 1 deletion src/mono/mono/mini/aot-compiler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4976,7 +4976,7 @@ add_full_aot_wrappers (MonoAotCompile *acfg)
csig->params [2] = m_class_get_byval_arg (mono_defaults.boolean_class);
add_method (acfg, get_runtime_invoke_sig (csig));

/* runtime-invoke used by finalizers */
/* runtime-invoke used by finalizers */
add_method (acfg, get_runtime_invoke (acfg, get_method_nofail (mono_defaults.object_class, "Finalize", 0, 0), TRUE));

/* This is used by mono_runtime_capture_context () */
Expand Down
Loading