Fix logging source generator CS0234 error with FormattableString namespace #118691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables logging generator tests to run on .NET Framework by adding multi-targeting support and handling framework-specific differences. The change allows better test coverage across different target frameworks.
Key changes:
- Adds .NET Framework support to the test project configuration
- Updates test code to handle .NET Framework API differences
- Fixes a namespace reference in the generator code
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Microsoft.Extensions.Logging.Generators.targets | Adds multi-targeting to include .NET Framework and includes required compatibility shim |
| LoggerMessageGeneratorEmitterTests.cs | Updates async file operations and string splitting for .NET Framework compatibility, adds platform-specific baseline adjustments |
| LoggerMessageGenerator.Emitter.cs | Corrects FormattableString namespace reference from CodeAnalysis to System |
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/area-extensions-logging |
|
@stephentoub I'll try to look at the related failures. |
|
CC @ericstj regarding last commit fixing the test build error. |
tarekgh
approved these changes
Aug 13, 2025
tarekgh
changed the title
This was referenced Aug 13, 2025
ericstj
approved these changes
Aug 14, 2025
jvanlangen
reviewed
Aug 15, 2025
Because those APIs don't exist on NET Framework where these tests now run. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118686.
This change fixes a regression introduced in the linked issue. It also enables the tests on .NET Framework, allowing us to catch similar issues in the future.