[Android] Disable ImportWithPasswordOrFileName_IterationCountLimitExceeded and HTTP tests #118733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
davidnguyen-tech
changed the title
davidnguyen-tech
changed the title
|
/azp run runtime-android,runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-android,runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
davidnguyen-tech
changed the title
davidnguyen-tech
changed the title
|
Do we need to exclude the entire project? Looking at the logs, the low memory killer seems to kick in when logs |
There was a problem hiding this comment.
Pull Request Overview
This PR disables the System.Security.Cryptography.Tests.csproj test project for CoreCLR Android x64 emulators by removing it from the smoke tests configuration. The change addresses issue #118603 where these tests were agreed to be disabled but were still executing in CI despite existing project exclusions.
Key changes:
- Removes the System.Security.Cryptography test project from Android CoreCLR smoke tests
- Also removes System.Net.Mail and System.Net.Http test projects from smoke tests (likely related cleanup)
Comments suppressed due to low confidence (1)
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kotlarmilos
changed the title
Thanks, let's test it. /cc: @akoeplinger I remember we disabled a single test recently due to OOM issue. |
|
yeah sounds good |
3 tasks
|
/ba-g Known issue reported #118766 |
vitek-karas
reviewed
Aug 18, 2025
| Assert.Contains(FwlinkId, ce.Message); | ||
| } | ||
|
|
||
| [SkipOnPlatform(TestPlatforms.Android, "Android emulators report OOM error")] |
There was a problem hiding this comment.
Can we reference the issue tracking this problem?
There was a problem hiding this comment.
I think longer term we should add some PlatformDetection.IsLowMemoryDevice helper or something like that, we've been using the Is64BitProcess in a couple places as a proxy and just assumed they'd have enough RAM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We agreed to disable failing test in
System.Security.Cryptography.Tests.csprojfor CoreCLR Android x64 (emulators) in #118603. At first glance, there were already project exclusions for the tests, but the tests were still being executed on the CI.This PR finally disables ImportWithPasswordOrFileName_IterationCountLimitExceeded from
System.Security.Cryptography.Tests.csprojand HTTP tests by removing them from Smoke Tests for CoreCLR Android.