Skip to content

Fix BuildChainForCertificateSignedWithDisallowedKey. #118777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

Fix BuildChainForCertificateSignedWithDisallowedKey. #118777

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d56565
Fix BuildChainForCertificateSignedWithDisallowedKey.
vcsjones Aug 15, 2025
db6ff18
Stop running BuildChainForCertificateSignedWithDisallowedKey on Linux…
vcsjones Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,6 +1112,7 @@ public static void BuildChainForFraudulentCertificate()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Linux, "Not supported on Linux.")]
public static void BuildChainForCertificateSignedWithDisallowedKey()
{
// The intermediate certificate is from the now defunct CA DigiNotar.
Expand Down Expand Up @@ -1177,12 +1178,11 @@ public static void BuildChainForCertificateSignedWithDisallowedKey()
chain.ChainPolicy.ExtraStore.Add(intermediateCert);
Assert.False(chain.Build(cert));

if (PlatformDetection.IsAndroid || PlatformDetection.IsApplePlatform26OrLater || PlatformDetection.IsLinux)
if (PlatformDetection.IsAndroid || PlatformDetection.IsApplePlatform26OrLater)
{
// Android always validates trust as part of building a path,
// so violations comes back as PartialChain with no elements
// Apple 26 no longer block these SKIs since the roots are no longer trusted at all and are expired.
// Linux has no concept of a blocked key list, they just remove certificates from a trust store.
Assert.Equal(X509ChainStatusFlags.PartialChain, chain.AllStatusFlags());
}
else
Expand Down
Loading