[release/9.0-staging] Disable release assert on disallowed thread re-initialization for managed C++ #118842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AaronRobinsonMSFT
added
area-Interop-coreclr
Servicing-consider
mangod9
approved these changes
Aug 18, 2025
jeffschwMSFT
approved these changes
Aug 18, 2025
|
Tagging subscribers to this area: @mangod9 |
jkoritzinsky
approved these changes
Aug 18, 2025
This was referenced Aug 18, 2025
Open
rbhanda
added
Servicing-approved
AaronRobinsonMSFT
merged commit 1080780
into
release/9.0-staging
99 of 104 checks passed
AaronRobinsonMSFT
deleted the
backport/pr-118827-to-release/9.0-staging
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #118827 to release/9.0-staging
/cc @AaronRobinsonMSFT @jkotas
Customer Impact
This issue was reported in #118741. In 9.0.5 servicing a more strict check was made for this case - running managed code in
DllMain. This more stricter case is now blocking IJW scenarios since the added assert will now trigger on all builds. This changes the assert to be non-retail builds for when IJW is involved, it is limited to scenarios involving IJW. This change is also not a fix as the underlying issue, running managed code inDllMain, since it represents a likely bug in MSVC. We are working with MSVC to get a fix for the underlying issue.Regression
Introduced in #113055. This created an explicit check for a case that has long been an invalid scenario - no managed code may run during
DllMain, see here.Testing
The scenario was repro 100 % of the time due to emitted code. Removing the all build asserts avoids the check and allows for a non-noisy shut down when IJW assemblies are loaded in the process.
Risk
Low. This change is limited to scenarios when IJW assemblies are loaded and reverts back to not checking invalid behavior instead of being explicit. This resets to 9.0.4 behavior when IJW is in the process.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.