[cDAC] ISOSDacInterface::GetAssemblyData #119007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-charlamb
force-pushed
the
cdac-getassemblydata
branch
from
259dfa9 to
12ce8e9
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements the GetAssemblyData method for the cDAC (Contract-based Debugging API for .NET Core) interface, replacing a stub implementation that previously delegated to the legacy DAC. The implementation provides assembly metadata including whether an assembly is dynamic, its module count, and parent domain information.
Key changes:
- Replace stub implementation with full cDAC-based
GetAssemblyDatamethod - Add support for detecting dynamic assemblies through new
IsDynamiccontract method - Include comprehensive debug validation against legacy DAC implementation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SOSDacImpl.cs | Implements GetAssemblyData method with assembly metadata retrieval and debug validation |
| ISOSDacInterface.cs | Defines DacpAssemblyData structure and updates method signature |
| Assembly.cs | Adds IsDynamic property to Assembly data contract |
| Loader_1.cs | Implements IsDynamic method in Loader contract |
| ILoader.cs | Adds IsDynamic method to ILoader interface |
| datadescriptor.inc | Adds IsDynamic field to Assembly type descriptor |
| assembly.hpp | Adds offset definition for IsDynamic field |
| Loader.md | Updates documentation with IsDynamic field and corrects typo |
rcj1
approved these changes
Aug 22, 2025
This was referenced Aug 22, 2025
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.