[release/10.0] [browser][ws] fix race condition during message and close events #119085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage event - fix status for wasm_ws_close_sent
github-actions
bot
requested review from
lewing and
pavelsavara
as code owners
pavelsavara
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
maraf
approved these changes
Aug 26, 2025
ilonatommy
approved these changes
Aug 26, 2025
lewing
approved these changes
Aug 26, 2025
Member
jeffschwMSFT
approved these changes
Aug 26, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can merge when ready
jeffschwMSFT
added
Servicing-approved
Member
|
This didn't fix the issue, we still see it happening in #117964 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #118887 to release/10.0
/cc @pavelsavara
Customer Impact
This is rare race condition revealed in CI runs.
#117964
Regression
Probably since #96618
Testing
Automated tests on CI. This is very difficult to reproduce.
Risk
Low - just delay processing of the event until next browser loop tick.