Skip to content

Conversation

@kg
Copy link
Member

@kg kg commented Aug 26, 2025

A few of the disabled crossgen2 tests seem to no longer fail so this re-enables them.
This also makes the disable broader for DevDiv_255294 because it has issues in more scenarios than the platform(s) where it's currently disabled.

@kg kg added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Aug 26, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 26, 2025
@kg
Copy link
Member Author

kg commented Aug 26, 2025

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kg
Copy link
Member Author

kg commented Aug 27, 2025

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kg
Copy link
Member Author

kg commented Aug 27, 2025

Based on this, the only one that needs to be blanket disabled anymore is ObjectStackAllocationTests.
HugeExpr1 is broken on x86 and DevDiv_255294 is broken on 32-bit ARM, it looks like. The latter may just be the existing OOM killer issue.

@kg
Copy link
Member Author

kg commented Aug 28, 2025

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kg added 2 commits August 28, 2025 16:00
…terloop run to see which ones are still broken
Move DevDiv_255294 to be a blanket all-platforms disable instead of ARM only, since its problem is related to memory usage
@kg kg force-pushed the r2r-disabled-test-audit-1 branch from 9ad6f8f to 5a02923 Compare August 28, 2025 23:02
@kg
Copy link
Member Author

kg commented Aug 29, 2025

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kg kg changed the title [NO MERGE] Batch re-enable disabled crossgen2 tests Update list of disabled crossgen2 tests Aug 29, 2025
@kg kg marked this pull request as ready for review August 29, 2025 18:01
@Copilot Copilot AI review requested due to automatic review settings August 29, 2025 18:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the list of disabled crossgen2 tests by re-enabling tests that no longer fail and broadening the scope of one test's exclusion. The changes involve removing exclusions for tests that have been fixed and moving a platform-specific exclusion to apply more broadly.

Key changes:

  • Re-enables several JIT tests that no longer fail with crossgen2
  • Moves DevDiv_255294 test exclusion from ARM-specific to general crossgen2 exclusions
  • Removes exclusions for arrays, force inlining, and CSE optimization tests

@kg kg removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Aug 29, 2025
@kg kg requested a review from mangod9 September 10, 2025 12:23
@kg kg merged commit dcf8680 into dotnet:main Sep 10, 2025
121 of 125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-crossgen2-coreclr needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants