[DAC] Properly configure BACKGROUND_GC check for the DAC
#119123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a DAC (Data Access Component) configuration bug where the background GC build variant flag was being set incorrectly. The issue was that the code was setting the build_variant_background_gc flag when background GC was not enabled, rather than when it was enabled.
- Corrects the conditional compilation directive from
#ifndef BACKGROUND_GCto#ifdef BACKGROUND_GC - Updates the corresponding comment to match the corrected logic
Comments suppressed due to low confidence (1)
max-charlamb
changed the title
BACKGROUND_GC DAC checkBACKGROUND_GC check for the DAC
hoyosjs
approved these changes
Aug 27, 2025
noahfalk
approved these changes
Aug 27, 2025
Maoni0
approved these changes
Aug 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while working on #119119
Diagnostics tests passed locally on the modified code