Skip to content

Conversation

@davidwrighton
Copy link
Member

  • This just enables the StubPrecode::GetMethodDesc api, as well as ExecutionManager::GetCodeMethodDesc
  • It is enough for !clrstack to work correctly

- This just enables the StubPrecode::GetMethodDesc api, as well as ExecutionManager::GetCodeMethodDesc
- It is enough for !clrstack to work correctly
Copilot AI review requested due to automatic review settings August 26, 2025 23:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables minimal debug stack walking support for the CLR interpreter by exposing necessary APIs for the !clrstack debugging command. The changes focus on enabling the StubPrecode::GetMethodDesc API and ExecutionManager::GetCodeMethodDesc to work with interpreter precodes.

Key changes:

  • Add support for interpreter precode handling in StubPrecode
  • Enhance ExecutionManager::GetCodeMethodDesc to recognize interpreter precodes
  • Add constructor overload to EECodeInfo for scan flag support

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/coreclr/vm/precode.h Adds forward declaration for InterpreterPrecode, AsInterpreterPrecode method, and updates GetMethodDesc to handle interpreter precodes
src/coreclr/vm/codeman.h Adds new constructor overload for EECodeInfo that accepts ExecutionManager::ScanFlag
src/coreclr/vm/codeman.cpp Implements interpreter precode detection and handling in ExecutionManager::GetCodeMethodDesc
Comments suppressed due to low confidence (1)

src/coreclr/vm/precode.h:353

  • The typedef for PTR_InterpreterPrecode is being removed here but it was moved to line 90. However, this creates a potential issue where the typedef is now defined before the actual InterpreterPrecode struct definition (which appears later in the file), which could cause compilation errors.
inline PTR_InterpreterPrecode StubPrecode::AsInterpreterPrecode()

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@davidwrighton davidwrighton merged commit 80f7aca into dotnet:main Aug 27, 2025
99 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants