Skip to content

Conversation

jkoritzinsky
Copy link
Member

Description

These members were meant to be preserved to enable utilization by other tools.

Customer Impact

Features meant to be built on these properties don't function.

Regression

No

Testing

Local validation with the tooling built on these APIs.

Risk

Low, only preserves members that were otherwise trimmed out.

@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 18:10
@jkoritzinsky
Copy link
Member Author

/backport to release/10.0

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR preserves Lock ID members in the ThreadBlockingInfo class to prevent them from being trimmed during IL linking. These properties are needed by external tooling that depends on these APIs for functionality.

Key Changes

  • Adds ILLink descriptor entries for ThreadBlockingInfo Lock ID properties
  • Prevents trimming of LockOwnerManagedThreadId and LockOwnerOSThreadId properties

Copy link
Contributor

github-actions bot commented Sep 2, 2025

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17412174592

@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Sep 2, 2025
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please get a code review. we will take for consideration in 9.0.x

@jeffschwMSFT jeffschwMSFT added this to the 9.0.x milestone Sep 2, 2025
@jkoritzinsky jkoritzinsky added the Servicing-consider Issue for next servicing release review label Sep 4, 2025
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 9, 2025
@rbhanda rbhanda modified the milestones: 9.0.x, 9.0.10 Sep 9, 2025
@jkoritzinsky jkoritzinsky merged commit df7805b into dotnet:release/9.0-staging Sep 10, 2025
152 of 156 checks passed
@jkoritzinsky jkoritzinsky deleted the 9.0-tbi-trimmer branch September 10, 2025 19:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Threading linkable-framework Issues associated with delivering a linker friendly framework Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants