-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[9.0] Preserve Lock ID Members #119281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0] Preserve Lock ID Members #119281
Conversation
/backport to release/10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR preserves Lock ID members in the ThreadBlockingInfo class to prevent them from being trimmed during IL linking. These properties are needed by external tooling that depends on these APIs for functionality.
Key Changes
- Adds ILLink descriptor entries for ThreadBlockingInfo Lock ID properties
- Prevents trimming of LockOwnerManagedThreadId and LockOwnerOSThreadId properties
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17412174592 |
Tagging subscribers to this area: @mangod9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. please get a code review. we will take for consideration in 9.0.x
df7805b
into
dotnet:release/9.0-staging
Description
These members were meant to be preserved to enable utilization by other tools.
Customer Impact
Features meant to be built on these properties don't function.
Regression
No
Testing
Local validation with the tooling built on these APIs.
Risk
Low, only preserves members that were otherwise trimmed out.