[release/10.0] Update Microsoft.NETCore.CoreDisTools nuget package from 1.5 to 1.6 #119357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows builds now enable /guard:cf. Also pick up a risc-v enhancement.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
@dotnet/jit-contrib PTAL Needed for compliance |
EgorBo
approved these changes
Sep 4, 2025
jeffschwMSFT
approved these changes
Sep 4, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can merge when ready
jeffschwMSFT
added
Servicing-approved
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Sep 4, 2025
Member
|
Build analysis seems to know about the failures but is still red... not sure why. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119334 to release/10.0
/cc @AndyAyersMS
Customer Impact
coredistools was flagged as out of compliance (was not built /guard:cf).
It is not part of the shipping product but is used in testing.
Regression
Testing
Verfied the 1.6 binary has /guard:cf enabled via dumpbin.
Risk
Low